search

mozilla / wp-calypso

INACTIVE - http://mzl.la/ghe-archive - The new JavaScript- and API-powered WordPress.com
https://developer.wordpress.com/calypso/
GNU General Public License v2.0
3 stars 10 forks source link

Add template options to sidebar #30

Closed mmmavis closed 8 years ago

mmmavis commented 8 years ago

Fixes #23

mmmavis commented 8 years ago

Note that the highlighting looks funky right now.

screen shot 2016-03-17 at 10 42 57 am

It is because the way Calypso sets the currently active nav item. Basically it checks the href URL of each sidebar item and compare it with the current page URL (using "startWith"). That's why if the current page path start with "page" (e.g., page, pages) all the Page related nav items will be highlighted (see screencap).

I'd say let's keep it as is for now. I don't wanna introduce tons of code changes to Calypso yet as changes could easily lead to unexpected errors somewhere off our radar...

mmmavis commented 8 years ago

Closing this as the fix will be covered in PR #31.