search

mozilla / wp-calypso

INACTIVE - http://mzl.la/ghe-archive - The new JavaScript- and API-powered WordPress.com
https://developer.wordpress.com/calypso/
GNU General Public License v2.0
4 stars 10 forks source link

Drop in mozmaker-templates #31

Closed mmmavis closed 8 years ago

mmmavis commented 8 years ago

This will fix #28 and #23

alicoding commented 8 years ago

LGTM

mmmavis commented 8 years ago

@alicoding could you review this PR again? Let me know if you want a quick walkthrough on this :bowtie:

alicoding commented 8 years ago

I think at this point I'm okay with your approach and we can improve it later. I have few suggestions, but I don't want to spend much time since this heartbeat will be really busy and this can be blocked even longer, so lets land this first ;)

mmmavis commented 8 years ago

@alicoding yea I wanted to get something working first. Let's file followup tickets for improvement!

mmmavis commented 8 years ago

@alicoding I'll leave it to you to hit the merge button! :smile:

alicoding commented 8 years ago

We don't have CSS from mozmaker anymore?

mmmavis commented 8 years ago

@alicoding we are hotlinking it directly: https://github.com/mozilla/wp-calypso/pull/31/files#diff-fd174879dd1b806db00fd900e74c9579R128 This way we don't have to re-deploy Calypso every time mozmaker or mozmaker-templates get updated. ( cc @gvn )