mozilla / zilla-slab

Mozilla's Zilla Slab Type Family
SIL Open Font License 1.1
419 stars 29 forks source link

Zilla Slab display issue in Nightly when viewed on fonts.google.com #12

Closed alexgibson closed 7 years ago

alexgibson commented 7 years ago

When I view the Zilla Slab page on Google Fonts in Firefox Nightly (56), the font does not display and there are several JS errors in the console.

screen shot 2017-07-05 at 10 46 04 am
alexgibson commented 7 years ago

This seems related to https://bugzilla.mozilla.org/show_bug.cgi?id=1331797

alexgibson commented 7 years ago

@m4rc1e - this issue only seems to effect the current Firefox Nightly (56), but I'm not clear if this is just an issue with the Google Fonts site, or an issue with the font itself. I do see a bunch of angular JS errors in the console. My main concern / question is: would this effect any site that loaded the Zilla Slab font hosted on fonts.google.com?

I don't see any issues with the font in use on https://www.mozilla.org/

m4rc1e commented 7 years ago

My Jsbin works on nightly.

screen shot 2017-07-05 at 10 54 59

http://jsbin.com/kaguwalene/edit?html,output

I guess this could be fonts.google.com

alexgibson commented 7 years ago

I can confirm the JSBin looks ok for me too

alexgibson commented 7 years ago

I do see a bunch of font validation errors in the console when I load the page on fonts.google.com. I don't see these errors on either the JSBin linked above, or on www.mozilla.org.

Does the Google Fonts site generate a subset for display purposes on the page maybe?

downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Zilla Slab script=all rev=1" style:normal weight:300 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=MIkI-zFTb-IKu6GQ4qfBISKvUU_cByiiRjMx5wKvR9oJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=ca4b45fc2d8284fd&v=v1 Zilla+Slab:1:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Zilla Slab script=all rev=1" style:normal weight:300 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=MIkI-zFTb-IKu6GQ4qfBISKvUU_cByiiRjMx5wKvR9oJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=ca4b45fc2d8284fd&v=v1 Zilla+Slab:1:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Zilla Slab script=all rev=1" style:normal weight:300 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=MIkI-zFTb-IKu6GQ4qfBISKvUU_cByiiRjMx5wKvR9oJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=ca4b45fc2d8284fd&v=v1 Zilla+Slab:1:12
downloadable font: rejected by sanitizer (font-family: "Zilla Slab script=all rev=1" style:normal weight:300 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=MIkI-zFTb-IKu6GQ4qfBISKvUU_cByiiRjMx5wKvR9oJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=ca4b45fc2d8284fd&v=v1 Zilla+Slab:1:12
downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Zilla Slab script=all rev=1" style:italic weight:300 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMr_NOk2J49LgE8wDheDydO77tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=2edace82e38b93fe&v=v1 Zilla+Slab:1:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Zilla Slab script=all rev=1" style:italic weight:300 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMr_NOk2J49LgE8wDheDydO77tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=2edace82e38b93fe&v=v1 Zilla+Slab:1:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Zilla Slab script=all rev=1" style:italic weight:300 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMr_NOk2J49LgE8wDheDydO77tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=2edace82e38b93fe&v=v1 Zilla+Slab:1:12
downloadable font: rejected by sanitizer (font-family: "Zilla Slab script=all rev=1" style:italic weight:300 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMr_NOk2J49LgE8wDheDydO77tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=2edace82e38b93fe&v=v1 Zilla+Slab:1:12
downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Zilla Slab script=all rev=1" style:italic weight:normal stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=0uwn9tpUNTyjFGXazfTluMTXOgDC9B_FcH8U4zq4d9pm090H82c3M7QG62zk4J1lZka1TUhbYSKvtufYEjCFpw&skey=9ce6a510b53c4ae1&v=v1 Zilla+Slab:1:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Zilla Slab script=all rev=1" style:italic weight:normal stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=0uwn9tpUNTyjFGXazfTluMTXOgDC9B_FcH8U4zq4d9pm090H82c3M7QG62zk4J1lZka1TUhbYSKvtufYEjCFpw&skey=9ce6a510b53c4ae1&v=v1 Zilla+Slab:1:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Zilla Slab script=all rev=1" style:italic weight:normal stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=0uwn9tpUNTyjFGXazfTluMTXOgDC9B_FcH8U4zq4d9pm090H82c3M7QG62zk4J1lZka1TUhbYSKvtufYEjCFpw&skey=9ce6a510b53c4ae1&v=v1 Zilla+Slab:1:12
downloadable font: rejected by sanitizer (font-family: "Zilla Slab script=all rev=1" style:italic weight:normal stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=0uwn9tpUNTyjFGXazfTluMTXOgDC9B_FcH8U4zq4d9pm090H82c3M7QG62zk4J1lZka1TUhbYSKvtufYEjCFpw&skey=9ce6a510b53c4ae1&v=v1 Zilla+Slab:1:12
downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Zilla Slab script=all rev=1" style:normal weight:500 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=M-lMpg6F7WVOVam88MR7yMiwI02_dWwr00A-w7_SazoJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=fa8b38d9fb8245bc&v=v1 Zilla+Slab:1:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Zilla Slab script=all rev=1" style:normal weight:500 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=M-lMpg6F7WVOVam88MR7yMiwI02_dWwr00A-w7_SazoJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=fa8b38d9fb8245bc&v=v1 Zilla+Slab:1:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Zilla Slab script=all rev=1" style:normal weight:500 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=M-lMpg6F7WVOVam88MR7yMiwI02_dWwr00A-w7_SazoJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=fa8b38d9fb8245bc&v=v1 Zilla+Slab:1:12
downloadable font: rejected by sanitizer (font-family: "Zilla Slab script=all rev=1" style:normal weight:500 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=M-lMpg6F7WVOVam88MR7yMiwI02_dWwr00A-w7_SazoJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=fa8b38d9fb8245bc&v=v1 Zilla+Slab:1:12
downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Zilla Slab script=all rev=1" style:italic weight:500 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMq4AyFqDea0dVgzXaIF6M2n7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=c3d6da9ec551b3ac&v=v1 Zilla+Slab:1:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Zilla Slab script=all rev=1" style:italic weight:500 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMq4AyFqDea0dVgzXaIF6M2n7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=c3d6da9ec551b3ac&v=v1 Zilla+Slab:1:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Zilla Slab script=all rev=1" style:italic weight:500 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMq4AyFqDea0dVgzXaIF6M2n7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=c3d6da9ec551b3ac&v=v1 Zilla+Slab:1:12
downloadable font: rejected by sanitizer (font-family: "Zilla Slab script=all rev=1" style:italic weight:500 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMq4AyFqDea0dVgzXaIF6M2n7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=c3d6da9ec551b3ac&v=v1 Zilla+Slab:1:12
downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Zilla Slab script=all rev=1" style:normal weight:600 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=idTxEJxWLSyMdm2hH0_fO9RH7GHtVaewoS3j7LxwR9gJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=b142959be4274cbf&v=v1 Zilla+Slab:1:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Zilla Slab script=all rev=1" style:normal weight:600 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=idTxEJxWLSyMdm2hH0_fO9RH7GHtVaewoS3j7LxwR9gJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=b142959be4274cbf&v=v1 Zilla+Slab:1:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Zilla Slab script=all rev=1" style:normal weight:600 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=idTxEJxWLSyMdm2hH0_fO9RH7GHtVaewoS3j7LxwR9gJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=b142959be4274cbf&v=v1 Zilla+Slab:1:12
downloadable font: rejected by sanitizer (font-family: "Zilla Slab script=all rev=1" style:normal weight:600 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=idTxEJxWLSyMdm2hH0_fO9RH7GHtVaewoS3j7LxwR9gJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=b142959be4274cbf&v=v1 Zilla+Slab:1:12
downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Zilla Slab script=all rev=1" style:italic weight:600 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMiTQREm9XUjMB8hzkw4VK1X7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=3a4040de6e68062&v=v1 Zilla+Slab:1:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Zilla Slab script=all rev=1" style:italic weight:600 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMiTQREm9XUjMB8hzkw4VK1X7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=3a4040de6e68062&v=v1 Zilla+Slab:1:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Zilla Slab script=all rev=1" style:italic weight:600 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMiTQREm9XUjMB8hzkw4VK1X7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=3a4040de6e68062&v=v1 Zilla+Slab:1:12
downloadable font: rejected by sanitizer (font-family: "Zilla Slab script=all rev=1" style:italic weight:600 stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMiTQREm9XUjMB8hzkw4VK1X7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=3a4040de6e68062&v=v1 Zilla+Slab:1:12
downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Zilla Slab script=all rev=1" style:normal weight:bold stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=5alS-fi1sAYG-KJydQxv8PW2HBc5F9KXbnjlXj3sAUYJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=fa01195928aed3f7&v=v1 Zilla+Slab:1:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Zilla Slab script=all rev=1" style:normal weight:bold stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=5alS-fi1sAYG-KJydQxv8PW2HBc5F9KXbnjlXj3sAUYJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=fa01195928aed3f7&v=v1 Zilla+Slab:1:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Zilla Slab script=all rev=1" style:normal weight:bold stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=5alS-fi1sAYG-KJydQxv8PW2HBc5F9KXbnjlXj3sAUYJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=fa01195928aed3f7&v=v1 Zilla+Slab:1:12
downloadable font: rejected by sanitizer (font-family: "Zilla Slab script=all rev=1" style:normal weight:bold stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=5alS-fi1sAYG-KJydQxv8PW2HBc5F9KXbnjlXj3sAUYJxswkgg5n4TuVaIY7ONlFgu7pLkZbft-7wfYe0GDvag&skey=fa01195928aed3f7&v=v1 Zilla+Slab:1:12
downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Zilla Slab script=all rev=1" style:italic weight:bold stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMsvVXI12avq5WsBRxcsbYxj7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=31b1451cc7b95f1d&v=v1 Zilla+Slab:1:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Zilla Slab script=all rev=1" style:italic weight:bold stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMsvVXI12avq5WsBRxcsbYxj7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=31b1451cc7b95f1d&v=v1 Zilla+Slab:1:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Zilla Slab script=all rev=1" style:italic weight:bold stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMsvVXI12avq5WsBRxcsbYxj7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=31b1451cc7b95f1d&v=v1 Zilla+Slab:1:12
downloadable font: rejected by sanitizer (font-family: "Zilla Slab script=all rev=1" style:italic weight:bold stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=SlbCHfLtf3uBEqmR9ezZMsvVXI12avq5WsBRxcsbYxj7tzEG6ZqJxR47jY1dOVAQzawOIcdrLB7LXQO_5azY-w&skey=31b1451cc7b95f1d&v=v1
m4rc1e commented 7 years ago

@alexgibson the fonts being loaded on fonts.google.com might be subsetted using an older version of fontTools for display purposes. Older versions had DFLT script tag issues. Unfortunately, I'm guessing here.

FF Nightly is probably using ots-sanitise, https://github.com/khaledhosny/ots.

cc @davelab6

Pomax commented 7 years ago

Did we update OTS? Zilla uses a rather creative version of the GSUB table (https://github.com/nodebox/opentype.js/issues/292 ran into this) and It's possible that OTS changed to reject this. Perhaps @khaledhosny has ideas here, too.

davelab6 commented 7 years ago

I confirm that the error is not in the upstream TTFs but in the derivatives served by the Google Fonts API. OTS was updated upstream so that this won't trigger, based on a clarification in the OT 1.8.2 spec, so if Firefox nightly builds in the latest OTS, the errors should stop.

khaledhosny commented 7 years ago

The reason such errors show in Nightly but not in Beta and Release is because sanitizing layout tables is enabled only in Nightly. Furthermore, as @davelab6 pointed out, this particular check has been dropped from OTS very recently and I think Nightly now has this version of it so such errors should soon not be present in an up to date nightly as well.

alexgibson commented 7 years ago

and I think Nightly now has this version of it so such errors should soon not be present in an up to date nightly as well.

I still see the same issue in the latest Firefox Nightly 57.0a1 (2017-08-03)

wisniewskit commented 7 years ago

I believe the font has now been fixed to work with nightly builds. Can someone else confirm that the font's page also appears properly for them on Firefox nightly?

davelab6 commented 7 years ago

Yep this fix should be there for all families, Roboto fixed as well

On Oct 18, 2017 8:15 PM, "Thomas Wisniewski" notifications@github.com wrote:

I believe the font has now been fixed to work with nightly builds. Can someone else confirm that the font's page also appears properly for them on Firefox nightly?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/zilla-slab/issues/12#issuecomment-337763457, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP9y3BTSHYe4eCnL-vWZj5keDOY77XXks5stpSjgaJpZM4OOGos .

scheinercc commented 7 years ago

Confirmed with 58.0a1 (2017-10-18). Thanks everyone!

image
alexgibson commented 7 years ago

Thanks for getting this fixed everyone, very much appreciated 💯