mozilla / zilla-slab

Mozilla's Zilla Slab Type Family
SIL Open Font License 1.1
419 stars 29 forks source link

Optimize build script #21

Open shinenelson opened 7 years ago

shinenelson commented 7 years ago

The build script was dependent on the directory in which it was triggered. This could cause inconsistency if the script was triggered from outside it's own directory.

The global variables allows the script to run with respect to the root of the repository allowing more flexibility, stability and consistency.

Also, there were multiple mv commands that could be merged into a single command.

alexgibson commented 7 years ago

/cc @m4rc1e

m4rc1e commented 7 years ago

@shinenelson thank you for the pr. I'll do a quick review.