search

mozillabrasil / sumo_live_helper

Helper Add-on for SUMO forum contributors
https://addons.mozilla.org/firefox/addon/sumo-live-helper-/
Mozilla Public License 2.0
7 stars 8 forks source link

Update to v1.2.0 #112

Closed jhonatasrm closed 4 years ago

jhonatasrm commented 4 years ago
dannycolin commented 4 years ago

Updated minimum version to 62.0

FYI, It still works on 58 :)

jhonatasrm commented 4 years ago

Updated minimum version to 62.0

FYI, It still works on 58 :)

Was a message from AMO.. (sidebar)

jhonatasrm commented 4 years ago

@dannycolin we have an error "Icon must be square" when submitted in AMO, so I changed the sumo.svg to sumo.png (sumo16.png, sumo32.png, sumo64.png) at manifest.json for now. We need to take a look at that after.

dannycolin commented 4 years ago

Updated minimum version to 62.0

FYI, It still works on 58 :)

Was a message from AMO.. (sidebar)

Strange. I guess we could even bump it to 68 since both 58 and 62 are End of Life. :P

"Icon must be square" when submitted in AMO, so I changed the sumo.svg to sumo.png (sumo16.png, sumo32.png, sumo64.png) at manifest.json for now. We need to take a look at that after.

Ah yes. I saw the warning today but didn't had the time to look at it. Thanks for the temporary patch ;).

jhonatasrm commented 4 years ago

Strange. I guess we could even bump it to 68 since both 58 and 62 are End of Life. :P

Yes... I don't see any problem, because this Add-on is for contributors, so they need the browser updated... hahahahhaha"

WesleyBranton commented 4 years ago

Updated minimum version to 62.0

FYI, It still works on 58 :)

Just for clarification, it needs Firefox 62 minimum because it uses the open_at_install property in the manifest for the sidebar.