search

mozillabrasil / sumo_live_helper

Helper Add-on for SUMO forum contributors
https://addons.mozilla.org/firefox/addon/sumo-live-helper-/
Mozilla Public License 2.0
7 stars 8 forks source link

Various UI fixes #134

Closed WesleyBranton closed 4 years ago

WesleyBranton commented 4 years ago

This pull request has a number of UI fixes and improvements in it. Most are for mobile, but there are some sidebar issues fixed in there too.

~Once it's merged into the main branch, an update should probably be pushed to AMO to make this version 1.4.1.~ ~Actually, hold off on the AMO update. I'm pretty sure I know what the problem is for issue 133.~ Ok, a release can be pushed to AMO once this is approved and merged. I fixed issue 133.

jhonatasrm commented 4 years ago

I really liked the changes, what do you think @dannycolin ?

🙂

dannycolin commented 4 years ago

Everything looks good but one small thing. I'm not sure about hiding the button in the sidebar. It isn't obvious, at first, that you can click on the question title "only" when the button is hidden. Also, it removes the indication that the action will open in a new tab.

WesleyBranton commented 4 years ago

Everything looks good but one small thing. I'm not sure about hiding the button in the sidebar. It isn't obvious, at first, that you can click on the question title "only" when the button is hidden. Also, it removes the indication that the action will open in a new tab.

It's difficult to signify that it will open in a new tab without some kind of visible icon. Any ideas?

dannycolin commented 4 years ago

It's difficult to signify that it will open in a new tab without some kind of visible icon. Any ideas?

Other than an icon no. Maybe we could add it, in a small form, directly at the end of the question title and give the title the same look as a like.

WesleyBranton commented 4 years ago

I'm going to merge this into the master branch and then we can decide how to mark the questions, if necessary.