search

mozillabrasil / sumo_live_helper

Helper Add-on for SUMO forum contributors
https://addons.mozilla.org/firefox/addon/sumo-live-helper-/
Mozilla Public License 2.0
7 stars 8 forks source link

Can select multiple languages to monitor (issue #61) #151

Closed WesleyBranton closed 4 years ago

WesleyBranton commented 4 years ago

This pull request allows users to select and monitor questions from multiple languages (resolves #61). Many contributors on SUMO answer questions from multiple languages, so this feature will be beneficial to them, as it makes it easier to see questions from different locales.

Additionally, I added a locale badge next to each question so that the users can easily see what language each question was posted to. This badge only displays if the user has more than one language selected, since it's not a necessary feature if the user is only watching one language.

SOME MINOR LOCALIZATION CHANGES MAY BE REQUIRED IN THE PREFERENCES UI

This pull request also adds and enables all of the locales that are currently supported on SUMO, regardless of whether or not the extension is localized for that language.

dannycolin commented 4 years ago

Additionally, I added a locale badge next to each question so that the users can easily see what language each question was posted to.

Do you think it would be possible to have a different color for every locales? For example, EN and ES are a bit hard to distinguish from each other currently.

Other than that it looks really great and it's indeed nice that the locale doesn't show up if you only have one set in the preferences :).

WesleyBranton commented 4 years ago

Do you think it would be possible to have a different color for every locales? For example, EN and ES are a bit hard to distinguish from each other currently.

I was thinking the same thing after submitting the pull request. I will add a commit to this pull request for that.

WesleyBranton commented 4 years ago

I added a commit that now colour-codes labels. Unfortunately, due to limited colour selection, not every label can consistently have white text, so there are a few locales that have black text to maintain good contrast from the background colour.