mozillabrasil / sumo_live_helper

Helper Add-on for SUMO forum contributors
https://addons.mozilla.org/firefox/addon/sumo-live-helper-/
Mozilla Public License 2.0
7 stars 8 forks source link

Hidden questions are shown while waiting for API results #166

Closed WesleyBranton closed 4 years ago

WesleyBranton commented 4 years ago

Likely because of my changes in pull request #159 to address issue #153, questions that have replies but are still within the 24 hour period are popping up on the list UI from the time the API call is made until the time that all of the API calls are returned. To be honest, I can't really pinpoint exactly where the issue is happening.

However, I already started a rewrite of some of the question list storage code, so I'll just work the solution for issue #153 into that so that it will wipe out this bug. On the plus side, everything seems to be running a little faster with some of the rewrite stuff I've already done.

Mostly I've just been simplifying the code to replace some of the loops with the cleaner array operations like findIndex() and filter(). I already have a local test version done, so I'll do some testing with it running in the browser tomorrow and, if it works as expected, will submit a PR.