mozillahispano / mozevents

Django app to handle Mozilla parties and events
http://www.mozilla-hispano.org
Other
10 stars 8 forks source link

Rama mapeveri #68

Closed mapeveri closed 7 years ago

mapeveri commented 9 years ago

Este pull request esta relacionado a este issue: https://github.com/mozillahispano/mozevents/issues/64

Lo que se hizo fue:

1) Agregar un crud de categorías. 2) En el crud de eventos permitir agregar una o más categorías por en el evento seleccionado. 3) En el detalle de evento se visualizan las categorías relacionadas al evento y al hacer click re direcciona a una vista que termina mostrando en un template los eventos relacionados a la categoría seleccionada. 4) En el index se agregó al final de todo las categorías, así al hacer click filtra los eventos por la categoría seleccionada.

nukeador commented 9 years ago

I did some review, comments inline. We use English for this kind of projects since we want to on board people from all around mozilla.

Also, I miss the migrations files for the model changes.

mapeveri commented 9 years ago

Ready the changes.

mapeveri commented 9 years ago

For apply the migrations, in the terminal:

1) python manage.py schemamigration events --auto 2) python manage.py migrate events

mapeveri commented 9 years ago

I Added slug to model category.

mapeveri commented 9 years ago

Ready @nukeador

francjp commented 9 years ago

No, one categorie, and possible multiple tags. I think that way it will be easier then to search for event type and event categorie

mapeveri commented 9 years ago

Well Then?

nukeador commented 9 years ago

Then we need just one category per event for now.

The tag thing is not currently a priority.

mapeveri commented 9 years ago

@nukeador ready ;)

nukeador commented 9 years ago

Seem OK for me.

@mapeveri Have you run the tests to ensure there is no problem?

@sebasmagri I don't have a lot of time this week, can you help with deploying this to production?

mapeveri commented 9 years ago

@nukeador No, I did the tests

sebasmagri commented 9 years ago

@nukeador justo esta semana estoy en medio de unos shipings pero si me das los detalles puedo hacerle deploy.

Saludos.

nukeador commented 9 years ago

@sebasmagri comprueba que no rompe nada y mergea. Cuando esté avisa y le doy en el server deploy, que mozevent solo tenemos en producción.

sebasmagri commented 9 years ago

@mapeveri I've left some comments to the changes.

Could you please add a database schema migration for your changes as well?

Best Regards,

mapeveri commented 9 years ago

@sebasmagri Have you attach migration by email ?. The .gitignore ignored the migrations folder.

nukeador commented 8 years ago

@sebasmagri Was the schema migration included? I can't find it in the file list :)

sebasmagri commented 8 years ago

@nukeador it wasn't. @mapeveri would you be able to push the migrations for this PR?

If there is no answer I'd be able to look at this next weekend.

mapeveri commented 8 years ago

@sebasmagri @nukeador I just made a commit with to migrations that I have.