search

mozillahispano / openwapp

OpenWapp is a open client for a well-known mobile IM service
65 stars 33 forks source link

French department of Martinique : no area code available #109

Open iolkan opened 9 years ago

iolkan commented 9 years ago

Hi, I'm trying to install openwapp in Martinique, but there's no area code available when I select this area, only a "+" symbol. Then it displays an error number if I try to register. (Open C ZTE phone) Thanks in advance! Iolkan

willyaranda commented 9 years ago

Ouch, it's true!

https://github.com/mozillahispano/openwapp/blob/master/app/scripts/countries.json#L7456

What is the country code?

Ping @duesenfranz as he is the creator of the original code and python converter.

duesenfranz commented 9 years ago

Oh yeah, that was an error in the csv file, which is however fixed by this commit.

This seems correct, and is also what google tells me...

@willyaranda , i re-ran the script and also added sorting to the json file for easier diffing in the future here; you think it's ready to push?

willyaranda commented 9 years ago

If it does not break anything, yeah :) Please upload the new version, and I will push a new version to the marketplace.

Thanks!

Timmaks commented 9 years ago

Don't push a new version to the narket place before my pr is committed. There is a l10n error in the currunt version of master who results in a white screen. Fixed by the latest pull request

iolkan commented 9 years ago

the code is +596 :)

  De : Guillermo López Leal <notifications@github.com>

À : mozillahispano/openwapp openwapp@noreply.github.com Cc : iolkan ndemengeon@ymail.com Envoyé le : Lundi 30 mars 2015 4h56 Objet : Re: [openwapp] French department of Martinique : no area code available (#109)

Ouch, it's true!https://github.com/mozillahispano/openwapp/blob/master/app/scripts/countries.json#L7456What is the country code?Ping @duesenfranz as he is the creator of the original code and python converter.— Reply to this email directly or view it on GitHub.

Timmaks commented 9 years ago

@willyaranda i planned to update the l10n files this Wednesday, can you wait till then with the push to marketplace so the work in transifex is in the next official build?

willyaranda commented 9 years ago

Yes, no problems.

2015-03-30 17:30 GMT+02:00 T.M. van den Broek notifications@github.com:

@willyaranda https://github.com/willyaranda i planned to update the l10n files this Wednesday, can you wait till then with the push to marketplace so the work in transifex is in the next official build?

— Reply to this email directly or view it on GitHub https://github.com/mozillahispano/openwapp/issues/109#issuecomment-87723508 .

Guillermo López [willyaranda] http://mozilla-hispano.org http://twitter.com/mozilla_hispano http://facebook.com/mozillahispano Certified Mozillian: https://mozillians.org/willyaranda

Timmaks commented 9 years ago

@duesenfranz please push this to the master so we can release a 1.8 version to the marketplace

Timmaks commented 8 years ago

@duesenfranz are you planning to fix this issue?