search

mozillahispano / twitta

Twitter client with ♥ for Firefox OS
https://twitta.pijusmagnificus.com/
12 stars 6 forks source link

Add SASS stylesheet #5

Open fjaguero opened 10 years ago

fjaguero commented 10 years ago

As plain CSS gets complex while adding more views, we should start using a pre-processor to have each view organized. By separating the CSS it will be easier to work as everything will be modularized.

Proposal

I can port/optimize the current CSS to SCSS and add a gulpfile that will handle the compilation. We can use node-sass to avoid the ruby version. The drawback is that not all the features are implemented but that won't be a problem in this case since it will be really straightforward.

Extra spicy

What do you think of using BEM-style for the classes. Why? This makes long-term readability and assures no spaghetti CSS. This is not a must but I recommend it.

willyaranda commented 10 years ago

I agree that we need gulp/grunt, because we will need more things in the future like minimization, packaging and even signing. No doubt.

About SASS, I don't know :) If you feel confident and @erick-bolinaga can help with this (the CSS is made by him, and I don't know if he knows SASS), let's do it.

About BEM-style, see above :)

fjaguero commented 10 years ago

Let's hear @erick-bolinaga opinion but in any case the use of SCSS will be mainly to take advantage of nesting. There's no need to "learn SASS" in this case.

fjaguero commented 10 years ago

@willyaranda I should probably email @erick-bolinaga, right?

willyaranda commented 10 years ago

Yeah, better 😀 El 10/09/2014 22:24, "Fernando Agüero" notifications@github.com escribió:

@willyaranda https://github.com/willyaranda I should probably email @erick-bolinaga https://github.com/erick-bolinaga, right?

— Reply to this email directly or view it on GitHub https://github.com/mozillahispano/twitta/issues/5#issuecomment-55177267.

fjaguero commented 10 years ago

@willyaranda I just added a gulpfile to the master branch by mistake (damn remotes!). I can rollback and make a PR anyway if needed.

erick-bolinaga commented 10 years ago

I don't know SASS or SCSS. Some of you could do it, if it is required.

fjaguero commented 10 years ago

The thing here is to organize the CSS by namespace, like .timeline-view .class, .dm-view .class, etc.

We won't be using any SASS feature, just nesting. I can do this and the you can review it.

willyaranda commented 10 years ago

@fjaguero sounds cool, please ask us for review once you have it!

fjaguero commented 10 years ago

Ok, working on in! :rocket:

fjaguero commented 9 years ago

I will not be prioritizing this by now.