search

mozillascience / PaperBadger

Issuing badges to credit authors for their work on academic papers
https://badges.mozillascience.org/
Mozilla Public License 2.0
95 stars 45 forks source link

New widget #150

Closed janhohner closed 8 years ago

janhohner commented 8 years ago

As discussed in #148 and Gitter I moved the code for the new widget to a seperate file. This provides solutions to #135 and #142 (I don't know if I should mark them as solved because these issues still exist in the original widget implementation).

This version of the widget currently only supports evergreen browsers and IE9+.

abbycabs commented 8 years ago

Thanks for the new PR! I'll take a closer look this afternoon :)

abbycabs commented 8 years ago

Looks great -- there's a couple comments I left in docs/widget.md that need to be looked at. Once that's clear, I think this is good to! :+1:

janhohner commented 8 years ago

Thanks for the review! I changed the docs in the necessary places.

abbycabs commented 8 years ago

Looks good to me! Merging