changes to make jshint happy

[josmas]

A few changes after running npm lint run. Tested on Firefox/Chrome.

I changed latedef = nofunc so that function definitions can be used before declaration, but not so variables (to avoid hoisting).

@acabunoc could you please review? thanks!

[abbycabs]

Hey @josmas thanks for your work here :)

We were originally using jshint (with that configuration!) since it was part of the Mozilla Foundation style guide. However, they migrated to eslint earlier this year.

I'll make an issue to migrate to the new style guide! Good catch with the quotes :) I'll take a closer look to make sure these changes don't have be reversed when we migrate to the new style guide.

Thanks again, Jos! Really appreciate your attention to detail here!

[abbycabs]

New issue for ESLint in #166

[josmas]

Hey @acabunoc I had a look at mofo-style and it turns out it is already installed; it is run through jscs when calling npm run lint, so I guess #166 is redundant.

[abbycabs]

Thanks @josmas! It's installed but I think we're just using it on jsbeautify https://github.com/mozillascience/PaperBadger/blob/master/package.json#L15 & jscs https://github.com/mozillascience/PaperBadger/blob/master/package.json#L12 (and an old versions I think!)

I'd like to update to use the new version that has eslint!

[josmas]

Hey @acabunoc yes, apologies I missed that one!

I have tried upgrading the package, but it seems like a much bigger jump that I had anticipated. More details in #166

[josmas]

@acabunoc I am finding that the same changes done here are needed for #166. Would you consider merging this one? Would be nice to have a little less work to do on the other side! :)

[abbycabs]

Done, thanks for flagging :)

[josmas]

Thanks @acabunoc I'll rebase the mofo branch I'm working on and take it from there!