josmas
commented
8 years ago Forgot to add; I purposely left 6 errors uncorrected. I thought they were important enough to be picked up one by one and refactored separately. For instance, this is something that appears in several files:
getBadges is defined in both line 27 and line 32, which are in the same scope. A good way to proceed here would be to write a unit test around the functionality before refactoring it, to make sure all is fine. But this needs to be looked at more carefully.
abbycabs
janhohner
This is a first step towards supporting the latest version of mofo-style as per #166
At the moment it uses a modified .eslintrc.yaml file, copied from the module and provided in the root folder, as a way to start the transition. It is a compromise, but fully supporting mofo-style would mean fully migrating to ES6, and it's a bit too much to do in just one step.
There are a number of things that can be done after this initial step, for instance, hook in babel presets and start using back-ticks instead of quotes (for strings), modify all variable names to camel case, or start using arrow functions instead of normal definitions. The final stage would be to completely get rid of the yaml file in the root folder and use the one in the module.