search

mozillascience / PaperBadger

Issuing badges to credit authors for their work on academic papers
https://badges.mozillascience.org/
Mozilla Public License 2.0
95 stars 45 forks source link

Refactoring #183

Closed jinankjain closed 8 years ago

jinankjain commented 8 years ago

@acabunoc I had tried to refactor the code but for writing unit test case I need some data that is already present in db so that I could check that test run are successful.

abbycabs commented 8 years ago

Thanks @jinankjain! I'll test this out tomorrow and compare with the work in #184 :)

If I forget please ping me!

abbycabs commented 8 years ago

Hey @jinankjain, I'd rather we wrote some tests first before I merge this in! Let me know if you need help

josmas commented 8 years ago

I am about to open a pull request that adds tests for this refactoring.

I don't think that the changes to the users/index.js file add much to the refactoring, though.

abbycabs commented 8 years ago

Assigned @josmas to review!

josmas commented 8 years ago

@jinankjain I cherry-picked your commit on top of the test changes. It is merged now. Thanks!