search

mozillascience / PaperBadger

Issuing badges to credit authors for their work on academic papers
https://badges.mozillascience.org/
Mozilla Public License 2.0
95 stars 45 forks source link

Update index.js #184

Closed amitkumarj441 closed 8 years ago

amitkumarj441 commented 8 years ago

Tried refactoring both functions - getTheBadges and getBadges.

abbycabs commented 8 years ago

Thanks @amitkumarj441! I'll take a look soon and see compare with #183 :)

abbycabs commented 8 years ago

Hey @amitkumarj441! Like I said in #183, I'd like to add tests before merging in any refactoring on this. Let me know if you need help!

amitkumarj441 commented 8 years ago

Hi @acabunoc,

I need some data in db to test this. Please review it.

Thank you Amit Kumar Jaiswal

josmas commented 8 years ago

@amitkumarj441 I am sorry but we are closing this one in favour of #183 + #186 because the code was more complete and already tested. Please let us know if you want to work on something else so we don't duplicate effort. You can catch us either on here or through Gitter. Thanks for your pull request!