mozillascience / PaperBadger

Issuing badges to credit authors for their work on academic papers
https://badges.mozillascience.org/
Mozilla Public License 2.0
95 stars 45 forks source link

More work on counts for paper routes as part of #125 #190

Closed josmas closed 8 years ago

josmas commented 8 years ago

This is part of the work in #125 for the /papers route.

josmas commented 8 years ago

I have also added counts for the /badges route.

josmas commented 8 years ago

Last piece of work for #125 is in now (user count route). I have also refactored a bit so that the code is consistent with other routes in both /users and /papers.

@acabunoc this is a large change, take your time reviewing; there are tests for all the routes, which should make things easier.

abbycabs commented 8 years ago

Thanks @josmas! I'll try to review today :)

abbycabs commented 8 years ago

This looks good to me! R+ once you update the assert for /papers/:doi1/:doi2/users/:orcid/badges/:badge/count

Feel free to merge once that's in :) Thanks for this, it's a huge lift!