search

mozillascience / PaperBadger

Issuing badges to credit authors for their work on academic papers
https://badges.mozillascience.org/
Mozilla Public License 2.0
95 stars 45 forks source link

upgrading to node 4.4.5; both the docker setup and the deployment set… #205

Closed josmas closed 8 years ago

josmas commented 8 years ago

…up for heroku. Closes #192

We decided to move to node 4 instead of 6, so will close #202 when this one is merged.

abbycabs commented 8 years ago

I'm getting this, not sure why:

23 passing (10s) 1 failing

1) Integration test against the real Badge server get all badges of a certain paper: Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.

I think saw someone else had this problem in the chat? Works fine for me on master

screen shot 2016-06-03 at 11 37 22

abbycabs commented 8 years ago

oh, it might be cause i'm on node 5.9 (I'm sleepy!) will try again :)

abbycabs commented 8 years ago

R+! It was my node version 👍

josmas commented 8 years ago

Thanks for the review!

Tests timeout at times; I guess the test-api server is slower than prod. I will merge this and separately add an additional couple of seconds to the mocha tests. Especially when the test server has to wake up, several tests will timeout the first time they are run.

abbycabs commented 8 years ago

You're right! I just tried again with node 5.9 and it works. I guess I was just impatient :)

andreabedini commented 8 years ago

I was getting that intermittently too