mozillascience / software-discovery-dashboard

MIT License
19 stars 8 forks source link

Fighshare API spec possible bug #49

Closed lukecoy closed 8 years ago

lukecoy commented 8 years ago

It seems that the author resource representation returned by Figshares API may not be returning what is entirely expected. Figshare calls these representations presenters.

Example: Article #1394809 should correspond to Figshare's Article Presenter Level 2, which at a glance it seems to do (Article Presenter L2 = L1 & L2 combined). Article Presenter L2 also contains an Author Presenter inside it.

If we take a closer look at the Author Presenter, it shows that ORCID is a field that you would expect to be returned, presumably if a specific author has an ORCID Figshare knows about. But Article #1394809 doesn't show an ORCID, even though the corresponding author, "Pedro Javier Villanueva Hernández" does have one on his figshare public profile. Seems like a bug.

Another example with a different article

TL;DR: There are multiple cases where Figshare's API isn't returning all the information I would expect. I think it probably means there's a bug in the API.

When this bug gets fixed (I'll make an issue on Fighshare's user_documentation repo), we should correct our author parsing for figshare to account for the change.

lukecoy commented 8 years ago

AH. API v1 doesn't specify ORCID. But V2 does. This isn't an issue, closing