search

mozillascience / software-discovery-dashboard

MIT License
19 stars 8 forks source link

Added border for search button for consistent styling #88

Closed amb8805 closed 8 years ago

amb8805 commented 8 years ago

for issue #87

mok4ry commented 8 years ago

Are we okay with the color of the search button text? I feel like we never explicitly set it, and I'm not quite in love with it. I also feel like this PR is a good place for that change to happen.

screen shot 2016-04-17 at 11 04 05 pm

amb8805 commented 8 years ago

I personally thing its okay. I played around with a lot of possible options for the search color etc, and i think it lets it stand out a bit. I'm not in love with it, but I like it more than the black one.

lukecoy commented 8 years ago

I'm not a UI person, we should / could ask Ricardo.. but I think the red font isn't really the color we're looking for. That makes the search seem like some sort of "Are you sure you want to do this?" action, similar to when you're deleting a repo from GitHub. It's just a search.

jmp3833 commented 8 years ago

LGTM :+1: