search

mozillascience / software-discovery-dashboard

MIT License
19 stars 8 forks source link

Add loading spinner and display it when results are loading #91

Closed mok4ry closed 8 years ago

mok4ry commented 8 years ago

This gets rid of the "No Results to Display" problem in Issue #81.

However, the sizing of the page is a little awkward with the results being replaced by a spinner and the main content div height changing so drastically. I'd rather address that in a separate issue/PR.

lukecoy commented 8 years ago

can we get a pic or is that kind of hard to do?

mok4ry commented 8 years ago

Yeah, I can put up a pic. Also I go back on my "I'd rather address [the awkward height change] issue in a separate PR" opinion and will attach some styling adjustments to this PR tomorrow.

mok4ry commented 8 years ago

loading-spinner cc @amb8805 @lukecoy @Lettuceman44

EDIT: gif is jumpy and grainy, real animation is very smooth.

lukecoy commented 8 years ago

Saw it in person, can confirm

lukecoy commented 8 years ago

looks good, I wonder about the file name case but yea

mok4ry commented 8 years ago

What do you mean different case filenames? Like how some of them are lowerUpper and some are UpperUpper?