Dashboard code review - Githubissues

mozillascience / studyGroup-GSOC

[project] repo for organizing goals and assets for the GSOC 2017 study group project

Mozilla Public License 2.0

5 stars 5 forks source link

Dashboard code review #10

Closed AnamikaD closed 7 years ago

AnamikaD commented 7 years ago

The Study Group Dashboard is inspired by Gentelella!! The Dashboard comprises of statistics from json data. The statistics are collected from sg-events.

Description: 1) "Total" tags are static (dynamic version yet to complete). 2) Download the files and add the full path of Data/*.json to js/Dashboard.js. If the full path is not mentioned, we may face Access to restricted URI denied issue. 3) Click on index3.js. Grab on Mozilla Study Group Dashboard!!

Please give feedback! Cheers!

AnamikaD commented 7 years ago

@auremoser Check this out!!!

auremoser commented 7 years ago

Very cool, I like the little graphs and it's a great prototype!

Two questions:

where does the dummy data come from?
do you think we can merge this with the study group events site?

Great work, well done!

AnamikaD commented 7 years ago

@auremoser Thank you for the review! <3 1) The dummy data is a random data, fetching correct data is incomplete. 2) Yes we can!! We can add the link to Study Group Event. We need to check that dashboard.js can access the JSON data. I will polish the site and may be add one or two graphs :) By the end of this week, we can merge this 💃

auremoser commented 7 years ago

Very exciting @AnamikaD ! Thank you for all your hard work!

AnamikaD commented 7 years ago

Thank you @auremoser ! All this because of your guide and motivation :D