Closed bensternthal closed 4 years ago
My suggestion is to use Git LFS and store assets
in a GitHub repo. On push, a GitHub Action would sync with a S3 bucket. Access would be managed on GitHub and no AWS credentials would be handed out to developers.
git-lfs
binary in your path. Get the binary from the official pagemaster
. We can fork https://github.com/marketplace/actions/s3-sync to make it support git-lfs.git clone git@github.com:mozilla/repo/with/assets
git lfs install
mkdir assets
git lfs track "assets/*"
git add .gitattributes
git commit -m "Track assets/ with git lfs"
dd if=/dev/urandom of=assets/50mb count=50 bs=1M
git add assets/50mb
git commit -m "Add 50mb file"
git push origin master
Thoughts @bensternthal @pmac @mozmeao/www ?
That sounds way easier than I thought! Does our GitHub plan support LFS for the mozmeao org or do we have to upgrade?
I should. I tried with a test org I run and it just worked.
Awesome. I guess my only other question then is if we should do this in the bedrock repo and just upload large files to our normal media s3 bucket, or keep it separate? I vote separate just because bedrock is already so large and we might use assets.m.o for other sites.
I agree on having separate repos.
asset-uploader
AWS user and assigned the existing groups asset-uploaders
asset-uploader
asset-uploader
Open questions
assets.moz.works
. Do we want to add assets.mozilla.com
?
Copied over from milestone board.