search

mozmeao / infra

Mozilla Marketing Engineering and Operations Infrastructure
https://mozilla.github.io/meao/
Mozilla Public License 2.0
58 stars 12 forks source link

Upgrade gitlab runners capacity #1359

Closed glogiotatidis closed 3 years ago

glogiotatidis commented 3 years ago

We're moving bedrock's integration tests to our runners, so increased CPU would benefit test run times.

We're currently on m5.large. I suggest that we move to c5a.xlarge with the same memory, double vCPUs, a stands for AMD.

Cost comparison Instance Type Frankfurt Oregon
m5.large $0.115 p hour ($82.8 p month) $0.096 ($69.12)
c5a.xlarge $0.174 ($125.28) $0.154 ($110.88)

Thoughts @pmclanahan @duallain @bensternthal ?

Related issue https://github.com/mozilla/bedrock/issues/9453

bensternthal commented 3 years ago

👍 💰

duallain commented 3 years ago

The proposed change seems good to me. Haven't used the AMD types before, so I'll be interested to see what performance gains we see.

One thing to note, I don't think we fully finished the work of having the gitlab runners update a security group when they get new IP addresses. If you wanted to take a swipe at that, that'd be great. Either way, it's worth double/triple checking that the runners can talk to all the k8s clusters after deployment. I usually just rerun infra-services or dev deployment jobs to double check.

glogiotatidis commented 3 years ago

We paired with @pmac and deployed new runners with fresh packer images in both regions. Also produced https://github.com/mozmeao/infra-services/pull/92