mozmeao / infra

Mozilla Marketing Engineering and Operations Infrastructure
https://mozilla.github.io/meao/
Mozilla Public License 2.0
59 stars 12 forks source link

Switch away from PII scrubbing in SaaS Sentry #1373

Closed stevejalim closed 2 years ago

stevejalim commented 2 years ago

We've been using self-hosted Sentry and the PII-scrubbing behaviour provided by it.

Now we're moving to SaaS Sentry and, while we trust it for PII scrubbing in the short term, it of course makes sense to scrub PII 100% before it leaves our systems.

Checklist

(link to relevant PR when it's ready)


Notes

AMO is using this approach which we could replicate and extend for MEAO services.

Mat in AMO and I briefly discussed collaborating on a shared library but it seems to make more sense for now (until we all know whether we want to scrub the same kind of info, in the same way) we should work separately on implementations.

Given we will be adding this behaviour to Bedrock, Basket, Nucleus and Snippets, we should consider whether we do it as a small library, or just replicated code.

stevejalim commented 2 years ago

Chatting about it with Pmac, let's go with code duplication and focusing on Basket as our main concern as that's the service which handles PII (+ a little in Bedrock, when it hands newsletter sign-ups to Basket)

pmac commented 2 years ago

I found sentry-processor as well, which we can maybe just use, or if not at least have as some further inspiration. It's not a very active project, but the code is fairly simple and easy to grok.

stevejalim commented 2 years ago

@pmac Giving sentry-processor a whirl