Setup fixups - Githubissues

mozmeao / snippets-service

Service powering snippets on Firefox's about:home.

https://snippets.mozilla.com

Mozilla Public License 2.0

31 stars 36 forks source link

Setup fixups #1535

Closed stevejalim closed 2 years ago

stevejalim commented 2 years ago

This changeset

Updates the Dockerfile's build deps for builder and prod images to allow build and tests to run Added:
- libffi-dev - for cffi
- zlib1g-dev - for Pillow
- libjpeg-dev - for Pillow
Updates README.md to include env setup step and remove reference to (non-existent) create_locales() helper

stevejalim commented 2 years ago

@pmac @robhudson - I'm splitting this work into smaller PRs to make it easier to review.

I'm still surprised I needed to add some build deps for the slim buster image in order to get Pillow and cffi to install at all, so def worth some extra eyes/thought why this might have become the case when the actual python reqs haven't moved

stevejalim commented 2 years ago

@pmac OK this is updated again to target Apple Silicon and (I think, based on searching around) this will fall back to non-ARM arch for intel/AMD.

Could you run make clean pull build test on your Intel mac to confirm, please?