search

moznion / radius-rs

An async/await native implementation of the RADIUS server and client for Rust.
MIT License
87 stars 14 forks source link

Add Cargo features and code to allow OpenSSL to be used for Crypto #40

Closed ramaravishankar closed 8 months ago

ramaravishankar commented 8 months ago

Hi - thanks for sharing this library!

This change is to add support for using OpenSSL for cryptography instead of the MD5 crate - for cases where only a trusted OpenSSL implementation is supported for anything cryptography related. There's no functional change to the output of the library.

I've added this as a cargo feature so that the MD5 crate is still used by default so as not to impact existing users who don't want the OpenSSL dependency. Using one feature doesn't compile in the dependencies of the other.

I've also added extra workflow steps to test the two feature options explicitly and confirmed these pass.

Let me know if you have any comments.

If you do accept, would you be able to tag a new release as well please?

Thanks again!

ramaravishankar commented 8 months ago

@moznion can I please get a feedback on this?

ramaravishankar commented 8 months ago

@moznion can I please get feedback on this?

moznion commented 8 months ago

@ramaravishankar Thank you for your contribution. Please give me a time to take a look at this.

ramaravishankar commented 8 months ago

@moznion sorry for bugging again, we have a dependency on this change, would it be possible for you to review this week?

moznion commented 8 months ago

@ramaravishankar I really appreciate your contribution! It seems some of Windows tests failed but the core of the change seems good. I'll merge this pull request and publish the new version which includes this change. Once it has been finished, I'll let you know that.

moznion commented 8 months ago

@ramaravishankar I published v0.4.0 which includes this change. Thank you for your contribution!

ramaravishankar commented 8 months ago

Thanks @moznion, cheers 🎉