mozzash / maven-replacer-plugin

Automatically exported from code.google.com/p/maven-replacer-plugin
MIT License
0 stars 0 forks source link

Params should have proper default annotation #74

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Mojo params should be properly annotated with default values so that they show 
up correctly in auto-generated docs. As it is now, most of the params aren't 
but have the default value just described in the text.

Original issue reported on code.google.com by anders.g...@gmail.com on 19 Sep 2012 at 11:52

GoogleCodeExporter commented 9 years ago
For example, this is what you should do:

        /**
         * Indicates if the token should be located with regular expressions.
         * This should be set to false if the token contains regex characters which may miss the desired tokens or even replace the wrong tokens.
         *
         * @parameter default-value="true"
         */
        private boolean regex;

I also see that you have expression="" on all your params. That's wrong, remove 
that!

Original comment by anders.g...@gmail.com on 19 Sep 2012 at 11:56

GoogleCodeExporter commented 9 years ago

Original comment by baker.st...@gmail.com on 21 Sep 2012 at 6:39

GoogleCodeExporter commented 9 years ago
Done and will be in the next release.
You can view the trunk code if you're interested.

Thanks again,
Steven

Original comment by baker.st...@gmail.com on 21 Sep 2012 at 8:05

GoogleCodeExporter commented 9 years ago
Released in 1.5.2.

Original comment by baker.st...@gmail.com on 17 Nov 2012 at 1:41