mozziemozz / M365CallFlowVisualizer

Reads a config from Microsoft 365 Phone System and renders them visually into a mermaid-js flowchart.
MIT License
91 stars 25 forks source link

Call-Flow Action-Disconnect Call, breaks the diagram #19

Closed sjackson0109 closed 2 years ago

sjackson0109 commented 2 years ago

Hi,

I've got a call-flow for a security department, that must advise 'if nobody is available immediately, to ask them to call-back in a few minutes'. I delivered this by passing the 'overflow timeout queue calls into another call-flow, specific to unanswered calls'. Where the call-action is to disconnect.

image

At the bottom of your generated .MD file is this section - the NO section is where the code breaks (missing the disconnect shape):

478da7f7-b9a8-4e43-8d22-9310bc0b00b8([Auto Attendant <br> Security Unanswered]) --> 
elementAfterHoursCheck478da7f7-b9a8-4e43-8d22-9310bc0b00b8{During Business Hours? <br> Time Zone: GMT Standard Time <br> Monday Hours: Closed <br> Tuesday Hours: Closed  <br> Wednesday Hours: Closed  <br> Thursday Hours: Closed <br> Friday Hours: Closed <br> Saturday Hours: Closed <br> Sunday Hours: Closed} -->|No|  
elementAfterHoursCheck478da7f7-b9a8-4e43-8d22-9310bc0b00b8{During Business Hours? <br> Time Zone: GMT Standard Time <br> Monday Hours: Closed <br> Tuesday Hours: Closed  <br> Wednesday Hours: Closed  <br> Thursday Hours: Closed <br> Friday Hours: Closed <br> Saturday Hours: Closed <br> Sunday Hours: Closed} -->|Yes| defaultCallFlowGreeting478da7f7-b9a8-4e43-8d22-9310bc0b00b8>Greeting <br> TextToSpeech <br> ''Sorry but the Chelse...''] --> defaultCallFlow478da7f7-b9a8-4e43-8d22-9310bc0b00b8((DisconnectCall))
mozziemozz commented 2 years ago

So this AA does nothing else except play the message and then disconnect? In your code example, the AA is closed on every day but your screenshot is showing the call flow for during business hours. I can't repro this if the AA has no business hours: image

If your AA is closed all the time, the "Call flow" part will never be active, only the "Call flow for after hours".

sjackson0109 commented 2 years ago

You are correct. This is the scenario where the call-diagram doesn't draw: AA 1 > welcome greeting > queue (on-hold music) > timeout > AA2 > Busy message > Disconnect

This diagram does draw: AA2 > Busy message > Disconnect

mozziemozz commented 2 years ago

Can you post a screenshot of the AA2? But again, why is your AA closed every day? I wasn't able to set it this way: image feel free to DM me more info / screenshots of your AAs configuration on Teams if you like. If I can't recreate your exact call flow, I can't trouble shoot this...

sjackson0109 commented 2 years ago

Sent you a direct message