Use term_painter instead of ansi_term

syxolk commented 7 years ago

For better Windows-compatibility, we should use term_painter instead of ansi_term. It works for Linux terminals, Windows PowerShell and Windows Command Prompt. term_painter is also largely api-compatible with ansi_term so no actual code changes were made in this PR.

Working towards #17

I've also tested termcolor but its API is pretty verbose and it seems to have issues with rayon's multithreading (it panics).

coveralls commented 7 years ago

Coverage remained the same at 61.337% when pulling 15ab872f45459ee46ea43f97b05fabb33f267a70 on syxolk:term-painter into 2aee54e38817ec73bfb408e33365a0418febf1a7 on mp4096:master.

mp4096 commented 7 years ago

Thanks for the PR! Unfortunately, I decided to close it.

Why:

I'd rather have a well-maintained dependency on its way to a 1.0 release. I can see it happening for termcolor, but not for term-painter
I am not sure whether we can easily make term-painter configurable (auto colour on or off depending on whether we're writing to stdout or piping into something different)

Instead, I think it would be better to have no feature instead of a badly implemented feature and to remove colours altogether. Could you please make a PR based on your no-colors branch?

mp4096 / indentex

Use term_painter instead of ansi_term #19