mp4096 / indentex

An indentation-based superset of LaTeX
MIT License
9 stars 2 forks source link

Auto deployment for windows using appveyor #34

Closed syxolk closed 7 years ago

syxolk commented 7 years ago
coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling a93b8ff2f824f492d79ee016ff15c6f91bb0cbf1 on issue-31-auto-deploy-windows into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling a93b8ff2f824f492d79ee016ff15c6f91bb0cbf1 on issue-31-auto-deploy-windows into on master.

mp4096 commented 7 years ago

First of all, thanks for the PR and all the work! This was a really nasty one. :nauseated_face:

Some questions:

mp4096 commented 7 years ago

Is it possible to avoid the Python / TOML dependency and parse (with regexen?) the output of indentex -V?

E.g. we could replace all whitespaces with an underscore and append _amd64 at the end.

syxolk commented 7 years ago

Is it possible to avoid the Python / TOML dependency and parse (with regexes?) the output of indentex -V?

Yes, Powershell has an integrated regex engine!

E.g. we could replace all whitespaces with an underscore and append _amd64 at the end.

We still need the clean version number to replace it in indentex_template.wxs.

Is it necessary to have a .gitignore in the packaging folder? Personally, I prefer a single .gitignore for the whole repo.

It felt more natural to put the .gitignore there but I could move it.

mp4096 commented 7 years ago

E.g. we could replace all whitespaces with an underscore and append _amd64 at the end.

We still need the clean version number to replace it in indentex_template.wxs.

Oh yeah, I didn't think about this.


I'd prefer a single .gitignore file. :upside_down_face:

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling a1696032421195b886bcd6cc94830ef098645fc5 on issue-31-auto-deploy-windows into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling a1696032421195b886bcd6cc94830ef098645fc5 on issue-31-auto-deploy-windows into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling ab12be9c940fa8590e0509619364b7a6a269d54b on issue-31-auto-deploy-windows into on master.

mp4096 commented 7 years ago

Great! :+1:

Thank you so much, this PR surely caused a lot of frustration.