Closed syxolk closed 7 years ago
First of all, thanks for the PR and all the work! This was a really nasty one. :nauseated_face:
Some questions:
.gitignore
in the packaging folder? Personally, I prefer a single .gitignore
for the whole repo.indentex -V
?--release
builds and install pandoc
and toml
only on tag events, in order to load AppVeyor as little as possible. Check out this branch: https://github.com/mp4096/indentex/tree/check-if-tagIs it possible to avoid the Python / TOML dependency and parse (with regexen?) the output of
indentex -V
?
E.g. we could replace all whitespaces with an underscore and append _amd64
at the end.
Is it possible to avoid the Python / TOML dependency and parse (with regexes?) the output of indentex -V?
Yes, Powershell has an integrated regex engine!
E.g. we could replace all whitespaces with an underscore and append _amd64 at the end.
We still need the clean version number to replace it in indentex_template.wxs
.
Is it necessary to have a .gitignore in the packaging folder? Personally, I prefer a single .gitignore for the whole repo.
It felt more natural to put the .gitignore
there but I could move it.
E.g. we could replace all whitespaces with an underscore and append
_amd64
at the end.We still need the clean version number to replace it in
indentex_template.wxs
.
Oh yeah, I didn't think about this.
I'd prefer a single .gitignore
file. :upside_down_face:
Great! :+1:
Thank you so much, this PR surely caused a lot of frustration.
pandoc
and the pythontoml
library.RUSTFLAGS
early to make it available intest_script
andbuild_script
indentex_template.wxs
indentex.msi
toindentex_[version]_[arch].msi
~Cargo.toml