mp4096 / indentex

An indentation-based superset of LaTeX
MIT License
9 stars 2 forks source link

Fix choco package issues #37

Open mp4096 opened 7 years ago

mp4096 commented 7 years ago

Ok, it seems like we missed some points and have some things to do:

Easy

BTW, what's the difference between package and project source URL? We need to dig into the choco wiki.

Not so easy

Blocked

Not applicable


See also https://github.com/chocolatey/package-validator/wiki/NuspecEnhancementsMissing

mp4096 commented 7 years ago

Well, this is almost done. I don't think we'll have website till 0.4.1, so I'll remove the milestone for now.

AdmiringWorm commented 7 years ago

BTW, what's the difference between package and project source URL? We need to dig into the choco wiki.

The difference is because usually the author of the software and the maintainer of the package isn't the same, so if the software is open source, the link to the repository (or to the page where the source can be downloaded from) would be added to the projectSourceUrl.

The packageSourceUrl is the source location of the package related files only (personally I prefer that the url includes the directory the package source is located in as well).

BTW, I recommend adding some more description to the choco package as well. Using for instance the description in the Readme.md file in this repo.

<description> Indentex is an indentation-based superset of LaTeX. An Indentex source file is more concise and visually less cluttered than an equivalent LaTeX file. Its indentation-based syntax was inspired by Python. Transpiling an Indentex source file yields a plain LaTeX file, which can be used further in your toolchain, sent to a publisher or your colleagues. </description>

In this case you could change to current description to be the summary instead, and then add the description I mentioned above.

BTW, the releaseNotes recommendation can be easily added by just adding a url to the Changelog file. ie

<releaseNotes>https://github.com/mp4096/indentex/blob/master/CHANGELOG.md</releaseNotes>
mp4096 commented 7 years ago

@AdmiringWorm Thanks! We've done it exactly as you suggested.

I have to update the description, however, seems like linebreaks in XML are preserved and the description looks not so good on the Chocolatey page.

AdmiringWorm commented 7 years ago

@mp4096 I had a quick look at the package, and as far as I can see everything looks good (I'll now more when the automated checks have ran).

Regarding the line breaks, I should probably have mentioned that hose are preserved. This have been mentioned to @ferventcoder in the past and most likely won't be changed anytime soon as it could affect existing package descriptions.

mp4096 commented 7 years ago

Cool!

I'm ok with line breaks, I think they're helpful when the description is long and needs to be structured.