search

mpadge / stellar

Search your github stars in R
MIT License
27 stars 3 forks source link

Graceful failures #12

Closed jonocarroll closed 6 years ago

jonocarroll commented 6 years ago

Add graceful failure routes, e.g. in stars: user = NULL, phrase = NULL. I'm happy to do this.

Alternatively, have useful defaults. Related to #7.

mpadge commented 6 years ago

Only exposed fn at present is

stars (phrase = "", user = NULL, language = NULL, newest_first = TRUE)

although no real param checks have been implemented. doing that would help a lot! Thanks!

mpadge commented 6 years ago

Great work @jonocarroll - happy to close this now?

jonocarroll commented 6 years ago

Yeah, I think it's pretty clean now re: unexpected failures.