search

mpadge / stellar

Search your github stars in R
MIT License
27 stars 3 forks source link

default phrase behaviour #20

Closed MHenderson closed 6 years ago

MHenderson commented 6 years ago

Hi,

The documentation for stars says:

phrase Text string to search for. Defaults to returning all starred repositories from the specified user

But this doesn't seem to be the case.

library(stellar)
#> 
#> Attaching package: 'stellar'
#> The following object is masked from 'package:graphics':
#> 
#>     stars

stars(user = "MHenderson", phrase = "stars")
#> [1] ropenscilabs/stellar :
#> Search your github stars in R
#> 
#> choose a repository to open, or anything else to exit:

stars(user = "MHenderson")
#> That text does not appear to describe any starred repositories

Best wishes, Matthew

jonocarroll commented 6 years ago

Thank you! That's my bad for the implementation of the default. Until I patch this (very soon) you can explicitly set phrase = NULL to achieve this (I think).

jonocarroll commented 6 years ago

Hopefully working now. Thanks again!

MHenderson commented 6 years ago

Yes, it does. Thanks!