`CONTRIBUTING.md` and Testing changes

[award28]

Per @mpalmer's request in #39, I've extracted the testing and contributing changes into a separate PR. This still includes the changes to save-snapshot.

@mpalmer Should we still maintain the run test binary? I don't see a reason why we would need to, but there may be something I'm not thinking of.

@bcheidemann From your comment here you mention

I think some minor updates are needed to tests/run.mjs (updating test to tests) and also the validation_state.snap.json files need to be added for the new test cases.

Could you lend me a hand on this PR to get those json files to work with the new testing approach?

[bcheidemann]

Could you lend me a hand on this PR to get those json files to work with the new testing approach?

@award28 Yeah of course :) There's two approaches we could take:

1) "fix" run.mjs now (this would be a very minor change) and integrate the testing approach in a follow-up PR 2) Integrate the testing approach in this PR and remove run.mjs

I've raised a quick fix for run.mjs in this PR. I'll start working on the changes needed to remove run.mjs now :) my preference would be to merge these changes as a separate PR since I don't want to risk unnecessarily delaying this one

[award28]

Definitely agree, thanks for the quick turn around! I've merged those changes into this branch. Based on feedback from #39, I should be good to remove the run binary and update CI.

[award28]

@mpalmer bumping this in case you missed it

[mpalmer]

Thanks for the bump, @award28, this slipped off my radar. I've put this on my list to review tomorrow; to answer your question:

Should we still maintain the run test binary?

Burninate it.

[bcheidemann]

Any update on this? Happy to pick up the changes requested if you don't have capacity @award28 :)

[mpalmer]

Hey @award28, do you have the bandwidth to push this through to completion, or shall @bcheidemann and myself finish it off and land it?