search

mpalmer / action-validator

Tool to validate GitHub Action and Workflow YAML files
GNU General Public License v3.0
277 stars 23 forks source link

Action-Validator Github Action Example #8

Closed mathew-fleisch closed 1 year ago

mathew-fleisch commented 2 years ago

Happy new year 😏

Hope all is well. I started using your action-validator directly in actions as a linting stage rather than a pre-commit hook. Thought I'd contribute back an example for this use case. Let me know if there is anything I can do on this PR (or the other one 😄).

mathew-fleisch commented 2 years ago

https://i.imgflip.com/6a48ie.jpg

mpalmer commented 2 years ago

I like what you're thinking, and I'm leaning towards just going all-out and just making the action-validator runs part of the test workflow. That would allow the README to just say "as an example of how to use action-validator+asdf in a GitHub workflow, see :arrow_right: over there!", rather than copy-pasting the examples. Sound reasonable, and are you up for reworking your PR in that direction?

mathew-fleisch commented 2 years ago

☝️ how's that?

mpalmer commented 1 year ago

I reworked this a little, fixed the conflicts, squashed it up, and committed as a46a8f3. Thanks for your contribution!