search

mpalmer / jekyll-static-comments

A plugin for Jekyll to implement a static-file based comments system
http://theshed.hezmatt.org/jekyll-static-comments/
GNU General Public License v3.0
195 stars 33 forks source link

Plugin crashes for Jekyll >= 1.1.0 #13

Open matze opened 11 years ago

matze commented 11 years ago

The static_comments.rb plugin crashes with 

$ jekyll serve --trace
Configuration file: /home/matthias/blog/_config.yml
            Source: /home/matthias/blog
       Destination: /home/matthias/blog/_site
      Generating... /var/lib/gems/1.8/gems/jekyll-1.1.2/bin/../lib/jekyll/post.rb:255:in `to_liquid': wrong number of arguments (1 for 0) (ArgumentError)

with Jekyll version 1.1.0 and 1.1.2. Versions 1.0.0 through 1.0.4 work fine.

My gut tells me it's that change that leads to the problem.

kctong529 commented 11 years ago

I have exactly the same problem. I use Jekyll version 1.2.1.

IQAndreas commented 11 years ago

If either of you are still having problems with it, making it compatible is actually a really simple fix: https://github.com/IQAndreas/jekyll-static-comments/commit/ce7808d9ef7a127bac52de470e6d83cbfaf78457

The plugin should also still be compatible with the older versions of Jekyll.

matze commented 11 years ago

Nice! Would be great though to see this merged upstream.

rwmpelstilzchen commented 11 years ago

Please merge @IQAndreas's solution.