search

mpalmer / lvmsync

Synchronise LVM LVs across a network by sending only snapshotted changes
http://theshed.hezmatt.org/lvmsync
GNU General Public License v3.0
380 stars 60 forks source link

Add SSH key option #29

Closed deriamis closed 9 years ago

deriamis commented 9 years ago

This would add an option to allow passing a file as the SSH key - for those who don't want to use the main id_rsa key for some reason (like me).

mpalmer commented 9 years ago

I'm not keen on the addition of an option just for SSH keys. Other programs that use SSH as a transport (eg rsync) have a single option to specify an "SSH command". I'd prefer to see that implemented in lvmsync. Would you be willing to rework your PR to reflect that?

Also, for SSH key config -- just use ~/.ssh/config <grin>

deriamis commented 9 years ago

Yeah, I had that thought myself about an hour after I made the commit. :) I'll set some time aside this weekend for it, since I will be working on the project that spawned the idea in the first place.

mpalmer commented 9 years ago

Excellent, thanks. I look forward to seeing your work.

deriamis commented 9 years ago

I haven't forgotten, by the way. I had a lot of schoolwork to do this last weekend, and time got away from me. I've put this on my task list for this coming Monday.

mpalmer commented 9 years ago

No rush -- I'm happy to let this sit until you've got time to hack.

deriamis commented 9 years ago

Well. This is what I get for working on a different workstation than I had planned... :|