search

mpanighetti / install-or-defer

A framework for prompting users of Jamf Pro-managed Macs to install Apple software updates.
Apache License 2.0
147 stars 28 forks source link

Is the script meant to keep caching the update after each deferal prompt? #46

Closed master-vodawagner closed 3 years ago

master-vodawagner commented 3 years ago

Not sure if this is an issue I've created because I've made some small changes to your code but "is the script meant to keep caching the update after each deferal prompt?"

Thu Nov 26 15:58:02 GMT 2020: The next prompt is deferred until after 2020-11-26 16:01:01. Thu Nov 26 16:18:02 GMT 2020: Starting install-or-defer.sh. Performing validation and error checking... Thu Nov 26 16:18:02 GMT 2020: Validation and error checking passed. Starting main process... Thu Nov 26 16:18:02 GMT 2020: Max deferral time undefined, or not set to a positive integer. Using default value. Thu Nov 26 16:18:02 GMT 2020: Maximum deferral time: 72h:00m:00s Thu Nov 26 16:18:02 GMT 2020: Deferral deadline: 2020-11-29 12:42:59 Thu Nov 26 16:18:02 GMT 2020: Time remaining: 68h:24m:57s Thu Nov 26 16:18:02 GMT 2020: Checking for pending system updates... Thu Nov 26 16:22:14 GMT 2020: Caching all system updates... Thu Nov 26 16:22:14 GMT 2020: Software Update Tool Finding available software Downloading macOS Big Sur 11.1 Beta Downloaded: macOS Big Sur 11.1 Beta Thu Nov 26 16:22:22 GMT 2020: Prompting to install updates now or defer... Thu Nov 26 16:22:52 GMT 2020: User clicked Defer after 00h:00m:30s. Thu Nov 26 16:22:52 GMT 2020: Next prompt will appear after 2020-11-26 19:22:52.

mpanighetti commented 3 years ago

Yeah, the repeated caching is intentional, to ensure that any new updates released in the middle of the deferral cycle also get cached. But if you have thoughts on how to check for an existing cache and bypass that caching (while still checking for and downloading new updates), I'm open to a PR. 🙂