mpark / variant

C++17 `std::variant` for C++11/14/17
https://mpark.github.io/variant
Boost Software License 1.0
659 stars 88 forks source link

Rename F type definition #64

Closed sieren closed 5 years ago

sieren commented 5 years ago

Hey,

first of all thanks for making this handy backport available 👍 I'm using the library on Arduino and unfortunately it won't compile due to a collision. This fix is pretty straight forward, if you want me to use a different name, I'm happy to fix it up.


Rename the overload_leaf operator type to something more specific, as F() causes collisions with the Arduino library, that defines this in their String library.

mpark commented 5 years ago

@sieren: are you saying that their library defines a macro named F...? 😵

I guess I'm fine with changing this... let's just call it impl, and I'll accept.

sieren commented 5 years ago

Haha, yeah it's weird 🧐 Fixed up the commit :)