mpark / variant

C++17 `std::variant` for C++11/14/17
https://mpark.github.io/variant
Boost Software License 1.0
659 stars 88 forks source link

PGI 19.5: no decltype(auto) #66

Closed ax3l closed 4 years ago

ax3l commented 4 years ago

The PGI pgc++ compiler with --c++11 in version 19.5 does not support decltype(auto) constructs from C++14. The proper test for this feature, as it is used for type deductions herein, is __cpp_decltype_auto.

Refs.: https://en.cppreference.com/w/cpp/feature_test https://gcc.gnu.org/projects/cxx-status.html

ax3l commented 4 years ago

@mpark CI seams to be a bit flaky right now. Can you please restart the travis CI runs that "failed" (curl timeout) and errored?

mpark commented 4 years ago

Restarted GCC 5 and 6 builds.

mpark commented 4 years ago

@ax3l: This looks good to me. Do you mind parenthesizing around the && please? I'd rather not depend on the operator precedence here.

ax3l commented 4 years ago

@mpark Agreed, scares me as well at that position.