mparker2
commented
6 years ago thanks for reading :)
I think this way of making comments with stackedit is good. there is a "rich diff" mode of the compare page on github which is useful for comparing the master branch to this one, it seems to work pretty well. The autosave committing is quite annoying but I suppose its unavoidable given that it isn't saving anywhere else. I will try to squash them once we are done with each section.
Karim asked me for more detail in various sections, I will add that to this branch too so that the master doesn't get too far ahead.
thanks again
Here is my first read-through of the introduction chapter.
You writing style is generally very good. I don't think that lanuage editing is going to be much of a thing if the rest of the thesis is like this. I don't know if you can find some way to do a charactor level diff. Still working out what the best way to do these edit is.
On general content I think it is good. There are some places where perhaps things feel a little bit skated over or missing in detail. I've flagged these places up in my comments. To view these comments go to stackedit.io and add your github account. You can then open files, pointing to this branch, and view, reply, act on and delete the comments. It will then sync back to github automatically. Its better to make sure you are working on a branch because the branch gets spammed by these commit messages every time it autosaves. You might also want to enable squash merging and do a squash merge on all these commints when we are read to merge the review.
Let me know if this way of doing things works for you, or you'd like to do it in some different way. I can work through your word version if that works better for you.