search

mpartel / bindfs

Mount a directory elsewhere with changed permissions.
https://bindfs.org/
GNU General Public License v2.0
442 stars 64 forks source link

reversed variant for --map-passwd and --map-group #113

Closed sshilovsky closed 2 years ago

sshilovsky commented 2 years ago

--map-passwd-rev and --map-group-rev

My use case for --map-group-rev is mounting /dev into chroot tree with different UID/GID. The other one was added just for completeness

sshilovsky commented 2 years ago

Please verify that the test on PR #73 is not skipped when it shouldn't be (3a1d2a1e265c43971f78ed1845920539ed00fd35). It's the first time I see ruby.

mpartel commented 2 years ago

Released as 1.16.1. Thanks!

(I left out the change for skipping the test if unshare failed, because I'm uncomfortable with silently skipping tests if something goes wrong. It'd be better to change the test system so that a single failure doesn't block other tests from running, but I have too little time to work on bindfs these days.)

sshilovsky commented 2 years ago

Thank you for prompt merge!

On unshare, it is a step in the process of initialization environment for that particular test. I think that it failing can only mean that the initialization is impossible here, so the test can be skipped, just like it's skipped currently based on parsing man unshare.

Although there is another possibility that my chroot, which I was running the tests inside, was set up wrong. I should look into that anyway.

mpartel commented 2 years ago

Yeah, making the tests work in a variety of environments is a totally valid way to look at it (and some test frameworks explicitly support it), I just tend to put a lot more weight on dangers of invisible failures.