search

mparticle-integrations / mparticle-android-integration-appboy

Braze (formerly Appboy) integration for the mParticle Android SDK
12 stars 14 forks source link

Add `-Xjvm-default=all` compiler arg to kit or docs #73

Closed mateot1 closed 2 years ago

mateot1 commented 2 years ago

I'm currently trying to resolve an issue with one of our CI builds when upgrading our mparticle version from 5.35.1 to 5.38.2 (it's a seemingly unrelated dependency resolution error but only happens on this build). The changelog for the past couple of releases of Braze/appboy have recommended adding freeCompilerArgs = ['-Xjvm-default=all'] to your build.gradle kotlinOptions. Adding this flag does seem to fix this particular error for some reason...

What I am wondering is: if this flag was added to the mparticle kit, would that mean consumers wouldn't have to? Or would it not make a difference since it's an api dependency? Is this something that should be mentioned in the docs/readme?

mateot1 commented 2 years ago

closing the issue for now as this might be a false alarm/red herring. might be an issue with a corrupted cache in CircleCI...