Check for OpenCV 2, 3 and 4

mpatacchiola / deepgaze

Computer Vision library for human-computer interaction. It implements Head Pose and Gaze Direction Estimation Using Convolutional Neural Networks, Skin Detection through Backprojection, Motion Detection and Tracking, Saliency Map.

MIT License

1.79k stars 478 forks source link

Check for OpenCV 2, 3 and 4 #88

Open kopetri opened 5 years ago

kopetri commented 5 years ago

Since there are multiple versions of opencv available, you should change your version tests cv2.__version__.split(".")[0] == '3' to something like int(cv2.__version__.split(".")[0]) >= 3

mpatacchiola commented 5 years ago

Hi @kopetri you are right, however at the moment we have not tested if everything is fine when using OpenCV > 3, therefore we cannot guarantee the correct functioning of the library.

If you want to contribute you are more than welcome to check if everything runs smoothly and send a pull request with the updated flag in all files. This should not take too long.