mpatric / mp3agic

A java library for reading mp3 files and reading / manipulating the ID3 tags (ID3v1 and ID3v2.2 through ID3v2.4).
MIT License
1.2k stars 310 forks source link

Refactoring. Replaced Integer with primitive type int #157

Closed ullenius closed 5 years ago

ullenius commented 5 years ago

Replaced Integer with primitive type int.

"It is rarely appropriate to use this constructor. The static factory valueOf(int) is generally a better choice, as it is likely to yield significantly better space and time performance."

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 68.578% when pulling 44a526222ce80a320196e6c48f1fc9489a2fd4e9 on ullenius:autoboxing into 7dbd34778e5b9ae498bb4efecb8d25d5e26ceb55 on mpatric:master.

tmzkt commented 5 years ago

I agree with your changes. Thank you for detailing all the reasons behind your change and for your contribution!