Minor test refactoring - Githubissues

mpatric / mp3agic

A java library for reading mp3 files and reading / manipulating the ID3 tags (ID3v1 and ID3v2.2 through ID3v2.4).

MIT License

1.2k stars 310 forks source link

Minor test refactoring #166

Closed ullenius closed 2 years ago

ullenius commented 5 years ago

Using try-with-resources with RandomAccessFile:

To ensure that the close() method is called
Previously, the call to file.close() was not in the finally block.

Using java.nio for file deletion:

The old code did not verify that the operation was succesful.
Now throwing IOException upon failure.

coveralls commented 5 years ago

Coverage remained the same at 71.21% when pulling b010abe31cf5f9e75f4f9495a8b0b939ed99fcc0 on ullenius:test-refactor into 9fd933b305d735554b3aed9355bb0ca4a18925bf on mpatric:master.

hennr commented 2 years ago

Thanks @ullenius !