search

mpcabd / python-arabic-reshaper

Reconstruct Arabic sentences to be used in applications that don't support Arabic
MIT License
398 stars 80 forks source link

Introducing get display to the library #10

Closed iamjazzar closed 7 years ago

iamjazzar commented 7 years ago

Introducing the get_display function will make the process more handy, since all the usages are meant to display the characters not only to reshape them.

mpcabd commented 7 years ago

While I agree that many people would have to call get_display on the reshaped text, I still don't think that this library should do that for them, because I know of some people who contacted me once regarding this library and they don't really need to call get_display, they just needed the reshaped text.

I can see anyway that your method here is to have a separate method that will call reshape and get_display, but that method is just there for usability for some people but it introduces a dependency on the python-bidi for all people.

I'm not really sure about this, I wonder what other people think?

iamjazzar commented 7 years ago

Having both methods allows users to use this library for different purposes that serve the same interest (A good looking Arabic text).

but that method is just there for usability for some people but it introduces a dependency on the python-bidi for all people.

Regarding this not, we can import python-bidi statement under get_display instead of importing it for the whole module.

However, it's really up to you deciding whether this change is really serving the library purposes or not.