search

mpcjanssen / simpletask-android

GNU General Public License v3.0
545 stars 124 forks source link

make app compatible with Android 10 gesture navigation #1070

Open aisbergde opened 4 years ago

aisbergde commented 4 years ago

some features can't be used on Android 10 because the app uses "reserved" global gestures like swipe from right or swipe from left.

aisbergde commented 4 years ago

I found that it works also on Android 10 if I perform this gesture in a higher area (maybe from top to 1/3 of the hight).

So there is no need to change the implementation. But it is very required to document this feature in the help file!

mpcjanssen commented 4 years ago

I am open for suggestions of how to make this more discoverable.

aisbergde commented 4 years ago

help > user interface this would be the right place to explain. There you explain how to use filters and there you could or should explain how to save and restore filters.

vise890 commented 2 years ago

I found that it works also on Android 10 if I perform this gesture in a higher area (maybe from top to 1/3 of the hight).

Is that still a thing? The only way I can get the drawer out is by putting my finger close to the edge (but not quite on it) and dragging from there..

aubreyz commented 2 years ago

Have you turned on gesture navigation in Android settings?. Turn it off - the old 3 buttons is much better.

( Android settings, system navigation)

We do need an alternative to the gesture in the app anyway

vise890 commented 2 years ago

Have you turned on gesture navigation in Android settings?. Turn it off - the old 3 buttons is much better.

( Android settings, system navigation)

We do need an alternative to the gesture in the app anyway

... hmm yes i have turned gestures on and I personally like them more than the buttons :smile:

It's just a minor annoyance, I just wanted to know if the old "perform gesture in higher area" is still a thing

smichel17 commented 2 years ago

Note that both drawers are accessible without swiping, although it is much less convenient. The left drawer is the hamburger in the upper left, and the right drawer is the "Saved filters" option at the bottom of the 3-dot menu (in the upper right).

I think I remember a way to disable left and right swipe gestures within your app, via AndroidManifest.xml. I am not sure, though; I would need to look it up. Edit: It needs to be done on a per-activity basis: https://developer.android.com/training/gestures/gesturenav#back-gestures Of course, this only allows the drawers to open; it does not make swipe-back gestures work to close the app.

mpcjanssen commented 2 years ago

Again a nice example of google breaking a common UI pattern without a clear alternative (except redesigning the UI)

jdckr commented 2 years ago

Just do a L/J like swipe from the edges. This works 95% of the time.

vise890 commented 2 years ago

Just do a L/J like swipe from the edges. This works 95% of the time.

sweet .. this works!

(boo google for breaking stuff tho!)

smichel17 commented 2 years ago

On second thought, I don't really see any value in being able to close ST by swiping from the side, since you can still use the swipe-from-bottom gesture to do that. The only time it would apply is launching ST from another app and wanting to get back to that app, and that's only applicable to the AddTask screen, not the main screen.

So I think just disabling swipe on the main screen (but leaving it in place for AddTask and the settings) would be a good, complete solution.

On Wed, Feb 2 2022 at 04:28:11 AM -0800, Martino Visintin @.***> wrote:

Just do a L/J like swipe from the edges. This works 95% of the time.

sweet .. this works!

(boo google for breaking stuff tho!)

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you commented.Message ID: @.***>

vise890 commented 2 years ago

hmm I don't know, i usually do swipe back to close apps, and it works everywhere else..

The J/L swipe is acceptable to me.

But also the https://developer.android.com/training/gestures/gesturenav#back-gestures seem to imply that you can exclude only a specific area of the screen, so for example a swipe higher up could open the drawer, while lower down it would still be a back gesture. I know 0 about android dev though so I can't be of much help..

mpcjanssen commented 2 years ago

@vise890 that seems to be the proposed solution from google indeed. I am wondering what to do in case someone is still using the navigation buttons though.

vise890 commented 2 years ago

I would have hoped google did the sensible thing and left the nav buttons behaviours unaffected when setting View#setSystemGestureExclusionRects... i.e. if you use nav buttons, you should be able to open the drawers with an inward swipe from anywhere on the left/right edge..

but that's just a hope :sweat_smile: