mpcjanssen / simpletask-android

GNU General Public License v3.0
543 stars 124 forks source link

[Enhancement] Add recurrence button to task creation/editting UI #1154

Open ImperialSquid opened 2 years ago

ImperialSquid commented 2 years ago

It's not immediately obvious that simpletask actually supports recurring tasks (I initially thought it didn't that that I'd have to implement it in lua...)

It would be really useful to have a button for defining the recurrent nature of a task when making or editing it. All you would need would be:

If the bar is getting a bit cramped it might be an idea to move the "time related" options, (ie due date, threshold date and recurrent nature) into their own pop up, either making it one long thing or maybe a pop up with tabs (I don't know if that's possible but I imagine it should be!)

smichel17 commented 2 years ago
  1. I agree it makes sense to have some UI for adding rec: rules, since it is one of the extensions supported "natively" (i.e. without using ST's scripting capability).

  2. The bar is getting a little long. I think one more item would not fit on small screens.

  3. I am reluctant to make some kind of "nested" UI here, pushing options into a menu. Having everything accessible in one tap is one of the main things that makes SimpleTask so usable, in my opinion; if you need to make a nested menu, there's already the edit button, and there's plenty of room on the edit screen to add additional menu items-- with the same number of button presses.

I think I'd be inclined to move the edit button out of the bottom bar. Not sure where to, but that makes room in the bottom bar for an item to edit the recurrence.

ImperialSquid commented 2 years ago

When selecting a task you get buttons at the top for sharing/archiving/deleting tasks, to me moving the edit button up there would be a good fit since they all deal with tasks directly in some way, whereas the ones on the bottom edit some part of a task (it's priority, due date, threshold, etc)

Alternatively, as I'm writing this up on GitHub mobile, I just noticed their markdown shortcuts are on a scrolling bottom bar:

Screenshot_20220328-052643_GitHub.jpg

Screenshot_20220328-052704_GitHub.jpg

That would be a good evergreen solution in case you wanted to add even more options in the future, plus it can probably be done in both the screen for making tasks, and when editting them, I don't think having a scrolling bar would break the ethos of simplicity right?

Grydpype commented 2 years ago

I definitely support this suggestion; thanks for bringing it up.

smichel17 commented 2 years ago

I opened #1182 to discuss making room in the bottom bar. One thing I noticed when revisiting this topic, though: on the edit screen, there are far fewer options in the bottom bar, so there is still room for a button like this.

lrq3000 commented 9 months ago

Please just make the action bar sliding just like what Markor does, I actually expected Simpletask to support this, I thought it was part of MaterialYou design. Anyway a sliding toolbar would allow to add optional utilities like that on all screen sizes while not cluttering more the base experience for the majority of users.